Messages in this thread | | | From | Kevin Hilman <> | Subject | Re: [PATCH 1/3] AM35x: voltage: Basic initialization | Date | Tue, 30 Aug 2011 15:26:28 -0700 |
| |
Abhilash K V <abhilash.kv@ti.com> writes:
> From: Sanjeev Premi <premi@ti.com> > > This patch adds the basic initialization of voltage layer > for AM35x. Since AM35x doesn't support voltage scaling, > Many functions have been defined to plug into existing > voltage layer. > > Signed-off-by: Sanjeev Premi <premi@ti.com> > Signed-off-by: Abhilash K V <abhilash.kv@ti.com>
[...]
> diff --git a/arch/arm/mach-omap2/voltagedomains3xxx_data.c b/arch/arm/mach-omap2/voltagedomains3xxx_data.c > index def230f..b45d145 100644 > --- a/arch/arm/mach-omap2/voltagedomains3xxx_data.c > +++ b/arch/arm/mach-omap2/voltagedomains3xxx_data.c > @@ -67,6 +67,38 @@ static struct omap_vdd_info *omap3_vdd_info[] = { > &omap3_vdd2_info, > }; > > +/* > + * AM35x VDD structures > + * > + * In AM35x there neither scalable voltage domain nor any hook-up with > + * voltage controller/processor. However, when trying to re-use the hwmod > + * database for OMAP3, definition of "core" voltage domain is necessary. > + * Else, changes in hwmod data structures grow spirally. > + * > + * As a workaround, "core" voltage domain is defined below. The definition > + * doesn't lead to any side-effects.
Except the side-effect of a bunch of unused data, and nop functions that just clutter things up in a not-very-maintainable way.
For SoCs without scalable voltage domains, we need to fix the underlying problems in the core code for how to cleanly re-use hwmods.
Fortunately, this core code cleanup is now in progress, so it shouldn't be long now where we can do this cleanly.
Kevin
| |