Messages in this thread | | | Date | Wed, 3 Aug 2011 16:34:26 -0700 | From | Greg KH <> | Subject | Re: [PATCH] nbd: nbd sysfs framework |
| |
On Wed, Aug 03, 2011 at 07:15:51PM -0400, Paul Clements wrote: > Description: The patch creates a new sysfs entry framework for nbd.
Why? What does this buy us except an increase in code size for no added benifit? You seem to be stripping out the driver layer here and using "raw" kobjects, why? That's generally never a good idea (hint, I think you just caused a race and userspace bug with your change as well because of this...)
confused,
greg k-h
| |