Messages in this thread | | | Date | Wed, 3 Aug 2011 21:18:28 +0200 | From | Oleg Nesterov <> | Subject | Re: + shm-fix-a-race-between-shm_exit-and-shm_init.patch added to -mm tree |
| |
On 08/03, Vasiliy Kulikov wrote: > > On Wed, Aug 03, 2011 at 16:04 +0200, Oleg Nesterov wrote: > > > > And since we rely on .in_use == 0, why we can't move this check > > outside of down_write/up_right to a) optimize the code and b) > > fix the problem? > > Agreed. But I second Linus that partial initialization only hides the > real problem. And some initcall chain movement is still needed.
I agree. But, until then, we can make a much more simple fix. Especially because this patch (imho) mostly hides the problem too.
Oleg.
| |