lkml.org 
[lkml]   [2011]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] oom: skip frozen tasks
On Fri 26-08-11 14:03:17, Konstantin Khlebnikov wrote:
> Michal Hocko wrote:
>
> >@@ -450,6 +459,10 @@ static int oom_kill_task(struct task_struct *p, struct mem_cgroup *mem)
> > pr_err("Kill process %d (%s) sharing same memory\n",
> > task_pid_nr(q), q->comm);
> > task_unlock(q);
> >+
> >+ if (frozen(q))
> >+ thaw_process(q);
> >+
>
> We must thaw task strictly after sending SIGKILL.

Sounds reasonable.

> But anyway I think this is a bad idea.

Why?

>
> > force_sig(SIGKILL, q);
> > }
> >

--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic


\
 
 \ /
  Last update: 2011-08-26 12:51    [W:0.067 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site