Messages in this thread | | | From | Bart Van Assche <> | Date | Fri, 26 Aug 2011 12:46:51 +0200 | Subject | Re: [PATCH 1/4] dynamic_debug: consolidate repetitive struct _ddebug descriptor definitions |
| |
On Thu, Aug 25, 2011 at 7:34 PM, Jason Baron <jbaron@redhat.com> wrote: > > +#define DECLARE_DYNAMIC_DEBUG_METADATA(name, fmt) \ > + static struct _ddebug __used __aligned(8) \ > + __attribute__((section("__verbose"))) name = { \ > + .modname = KBUILD_MODNAME, \ > + .function = __func__, \ > + .filename = __FILE__, \ > + .format = fmt, \ > + .lineno = __LINE__, \ > + .flags = _DPRINTK_FLAGS_DEFAULT, \ > + .enabled = false, \ > + }
A minor remark: macro arguments are usually surrounded by parentheses in a macro definition. That's not the case for "fmt" in the above.
Bart.
| |