Messages in this thread | | | Date | Fri, 26 Aug 2011 02:13:46 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH] slab: trivial: cleanup: remove unneeded return |
| |
On Fri, 26 Aug 2011, Zhao Jin wrote:
> Terribly sorry. It was gmail who wrapped the line. > Please see this following version. Thanks! >
It's still whitespace damaged, please see Documentation/email-clients.txt. If it doesn't help, please add to that document with whatever eventually works for you, it will help many people in the future!
This probably shouldn't be cc'd to trivial, it's a candidate to go through Pekka's slab tree. And once you get the email client sorted out or Pekka decides to do it manually, feel free to add my
Acked-by: David Rientjes <rientjes@google.com>
even though you forgot the changelog and your own signed-off-by line on this one :)
> --- > mm/slab.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/slab.c b/mm/slab.c > index 6d90a09..82e0a0e 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -3678,13 +3678,12 @@ static inline void __cache_free(struct kmem_cache > *cachep, void *objp, > > if (likely(ac->avail < ac->limit)) { > STATS_INC_FREEHIT(cachep); > - ac->entry[ac->avail++] = objp; > - return; > } else { > STATS_INC_FREEMISS(cachep); > cache_flusharray(cachep, ac); > - ac->entry[ac->avail++] = objp; > } > + > + ac->entry[ac->avail++] = objp; > } > > /**
| |