Messages in this thread | | | From | Paul Menage <> | Date | Thu, 25 Aug 2011 02:32:35 -0700 | Subject | Re: [PATCH 3/6] cgroup: introduce cgroup_taskset and use it in subsys->can_attach(), cancel_attach() and attach() |
| |
On Thu, Aug 25, 2011 at 2:20 AM, Tejun Heo <tj@kernel.org> wrote: > > I think having separate ->attach() and ->attach_task() is inherently > broken. Look at the memcg discussion I had in this thread for > reference and as soon as we need to do something across the tasks > being migrated, iteration-by-callback becomes very painful. > e.g. let's say memcg wants to find the mm->owner and wants to print > warning or fail if that doesn't work out. How would that be > implemented if it's iterating by callback.
OK, fair point. See my other email for patch comments.
Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |