lkml.org 
[lkml]   [2011]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]arm: nwfpe: '&pointer[0]' to 'pointer' fix
On Thu, Aug 25, 2011 at 10:11:43PM +0300, Maxin B. John wrote:
> '&pointer[0]' to 'pointer' fix in arch/arm/nwfpe/fpa11_cpdt.c

Your reason being?

> #ifdef __ARMEB__
> - get_user(p[0], &pMem[0]); /* sign & exponent */
> + get_user(p[0], pMem); /* sign & exponent */
> get_user(p[1], &pMem[1]);

You may notice the original code has some consistency. Your replacement
is less consistent. If you wish to make this change, it should change to:

get_user(p[0], pMem + 0);
get_user(p[1], pMem + 1);

to maintain consistency.


\
 
 \ /
  Last update: 2011-08-25 21:17    [W:0.071 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site