Messages in this thread | | | Date | Wed, 24 Aug 2011 14:03:11 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 1/4] x86: base support for the TS-5500 platform |
| |
On 08/24/2011 01:23 PM, Vivien Didelot wrote: > + > +/** > + * ts5500_pre_detect() - check for TS-5500 specific features > + * > + * It is not safe to read ID register if we are not sure that it's a TS SBC. > + * Since TS SBCs don't have DMI support, it is safer to check for a TS-5500 > + * specific feature such as the processor. > + */ > +static int ts5500_pre_detect(void) > +{ > + /* Check for AMD ElanSC520 Microcontroller */ > + if (!(cpu_info.x86_vendor == X86_VENDOR_AMD && > + cpu_info.x86 == AMD_ELAN_FAMILY && > + cpu_info.x86_model == AMD_ELAN_SC520)) > + return -ENODEV; > + > + return 0; > +} > +
Doesn't this mean you will read this unsafe register on any Elan SC520 platform? Is that okay?
-hpa
| |