lkml.org 
[lkml]   [2011]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] x86: base support for the TS-5500 platform
On 08/24/2011 01:23 PM, Vivien Didelot wrote:
> +
> +/**
> + * ts5500_pre_detect() - check for TS-5500 specific features
> + *
> + * It is not safe to read ID register if we are not sure that it's a TS SBC.
> + * Since TS SBCs don't have DMI support, it is safer to check for a TS-5500
> + * specific feature such as the processor.
> + */
> +static int ts5500_pre_detect(void)
> +{
> + /* Check for AMD ElanSC520 Microcontroller */
> + if (!(cpu_info.x86_vendor == X86_VENDOR_AMD &&
> + cpu_info.x86 == AMD_ELAN_FAMILY &&
> + cpu_info.x86_model == AMD_ELAN_SC520))
> + return -ENODEV;
> +
> + return 0;
> +}
> +

Doesn't this mean you will read this unsafe register on any Elan SC520
platform? Is that okay?

-hpa



\
 
 \ /
  Last update: 2011-08-24 23:05    [W:0.052 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site