lkml.org 
[lkml]   [2011]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [GIT PULL] drbd-8.4 for mainline
On Wed, Aug 24, 2011 at 14:16, Pekka Enberg <penberg@kernel.org> wrote:
> On Wed, Aug 24, 2011 at 8:54 PM, Jens Axboe <axboe@kernel.dk> wrote:
>> So, please do this right. The email you sent is perfect for a 0/N header
>> email, then each patch must follow as a reply to that. There's git
>> send-email to help you with this. If you haven't used it before, I'd
>> advise you to do a dry-run or two to your own email address to ensure
>> that it produces the right result. When it does, then send it off to
>> lkml and myself. Then I too will see reviews and have a better chance of
>> judging whether this is mergeable now or not.
>
> Another thing: there's roughly 500 commit in the pull request. Please
> don't send all of them at the same time if you want people to take a
> look at them.

Clearly you've been developing DRBD 8.4 for quite a while; it will save you
a lot of time overall in the future to submit patches as soon as you have
each one ready for review.

You should be merging functional and code improvements continuously
into every release window, instead of batching them up and submitting
500 at a time.

Cheers,
Kyle Moffett


\
 
 \ /
  Last update: 2011-08-24 21:35    [W:0.126 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site