Messages in this thread | | | Date | Wed, 24 Aug 2011 12:31:26 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH] oom: skip frozen tasks |
| |
On Wed, 24 Aug 2011, Michal Hocko wrote:
> When we are in the global OOM condition then you are right, we have a > higher chance to panic. I still find the patch an improvement because > encountering a frozen task and looping over it without any progress > (even though there are other tasks that could be killed) is more > probable than having no killable task at all. > On non-NUMA machines there is even not a big chance that somebody would > be able to thaw a task as the system is already on knees. >
That's obviously false since we call oom_killer_disable() in freeze_processes() to disable the oom killer from ever being called in the first place, so this is something you need to resolve with Rafael before you cause more machines to panic.
| |