| Date | Tue, 23 Aug 2011 15:51:50 -0700 | From | Greg KH <> | Subject | Re: [PATCH 020/117] Staging: hv: vmbus: Support the notion of id tables in vmbus_match() |
| |
On Fri, Jul 15, 2011 at 10:46:08AM -0700, K. Y. Srinivasan wrote: > Introduce code to handle driver specific id tables to the vmbus core > (vmbus_match). This would allow us to handle more than one device type > with a given driver. > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> > --- > drivers/staging/hv/vmbus_drv.c | 21 ++++++++++++++++----- > 1 files changed, 16 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c > index 7baba62..3a8eb36 100644 > --- a/drivers/staging/hv/vmbus_drv.c > +++ b/drivers/staging/hv/vmbus_drv.c > @@ -255,21 +255,32 @@ static int vmbus_uevent(struct device *device, struct kobj_uevent_env *env) > return ret; > } > > +static bool is_not_null_guid(const __u8 *guid)
Negative function names cause people's heads to get confused.
Please do "is_null_guid()" instead.
thanks,
greg k-h
|