Messages in this thread | | | From | Kevin Hilman <> | Subject | Re: [PATCH 3.1-rc3] gpio/omap: fix build error with certain OMAP1 configs | Date | Tue, 23 Aug 2011 10:11:47 -0700 |
| |
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> writes:
> With commit f64ad1a0e21a, "gpio/omap: cleanup _set_gpio_wakeup(), remove > ifdefs", access to build time conditionally omitted 'suspend_wakeup' > member of the 'gpio_bank' structure has been placed unconditionally in > function _set_gpio_wakeup(), which is always built. This resulted in the > driver compilation broken for certain OMAP1, i.e., non-OMAP16xx, > configurations. > > Really required or not in previously excluded cases, define this > structure member unconditionally as a fix. > > Tested with a custom OMAP1510 only configuration. > > Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Verified that this fixes a build problem when building for OMAP1 (730/850 only)
Acked-by: Kevin Hilman <khilman@ti.com>
Grant, can you queue this as a fix for 3.1-rc?
Thanks,
Kevin
| |