lkml.org 
[lkml]   [2011]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3.1-rc3] gpio/omap: fix build error with certain OMAP1 configs
Date
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> writes:

> With commit f64ad1a0e21a, "gpio/omap: cleanup _set_gpio_wakeup(), remove
> ifdefs", access to build time conditionally omitted 'suspend_wakeup'
> member of the 'gpio_bank' structure has been placed unconditionally in
> function _set_gpio_wakeup(), which is always built. This resulted in the
> driver compilation broken for certain OMAP1, i.e., non-OMAP16xx,
> configurations.
>
> Really required or not in previously excluded cases, define this
> structure member unconditionally as a fix.
>
> Tested with a custom OMAP1510 only configuration.
>
> Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>

Verified that this fixes a build problem when building for OMAP1
(730/850 only)

Acked-by: Kevin Hilman <khilman@ti.com>

Grant, can you queue this as a fix for 3.1-rc?

Thanks,

Kevin


\
 
 \ /
  Last update: 2011-08-23 19:15    [W:0.078 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site