Messages in this thread | | | Date | Tue, 23 Aug 2011 17:42:39 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 04/16] freezer: implement and use kthread_freezable_should_stop() |
| |
Hi Tejun,
On 08/22, Tejun Heo wrote: > > > OK, but then we do > > > > current->flags &= ~PF_FREEZING; > > > > since PF_FROZEN wasn't cleared this can race with > > > > p->flags &= ~PF_FROZEN; > > > > No? > > Indeed, I removed PF_FREEZING and moved PF_FROZEN to __refrigerator() > in later patches, so it's already gone.
OK, thanks.
> Patches could have been > sequenced better, I suppose. But, sequencing fixes for different > races was already pretty challenging. :)
... and it also makes sense to try to read the whole seried before asking the question.
although this is not simple. Especially because currently I can't read it faster than one patch per day ;)
Oleg.
| |