lkml.org 
[lkml]   [2011]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/4] debug-pagealloc: add support for highmem pages
From
2011/8/23 Andrew Morton <akpm@linux-foundation.org>:

> This seems more complicated than is needed.  Couldn't we just do
>
> static void poison_page(struct page *page)
> {
>        void *addr;
>
>        preempt_disable();
>        addr = kmap_atomic(page);
>        set_page_poison(page);
>        memset(addr, PAGE_POISON, PAGE_SIZE);
>        kunmap_atomic(addr);
>        preempt_enable();
> }
>
> ?

This code looks much better. I'll update the patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-08-23 17:29    [W:0.041 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site