lkml.org 
[lkml]   [2011]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [uml-devel] SYSCALL, ptrace and syscall restart breakages (Re: [RFC] weird crap with vdso on uml/i386)
    On Mon, Aug 22, 2011 at 5:07 PM, H. Peter Anvin <hpa@zytor.com> wrote:
    >
    > Checking for SYSCALL in the vdso is cheap... the only problem is if
    > someone thinks that they can copy it out of the vdso and run it, having
    > special-cased SYSENTER already, but not SYSCALL.  The recent experience
    > shows that that is apparently a very real possibility.

    I don't understand why people keep harping on this "copy the vdso" thing.

    Guys, IF THEY COPY THE VDSO, THEN THEY WOULD GET OUR IMPROVEMENTS!

    So stop being silly.

    As to comparing the IP address, that's just moronic. Why the hell
    would anybody ever do something that stupid? It's expensive and not
    worth it. You'd be much better off comparing the contents of the
    memory at 'rip', and see if that memory contains the 'int 0x80'
    instruction we would add. That automatically also gets the 'somebody
    copied the vdso text' case right.

    You guys seem to positively _want_ to make this a bigger issue than it
    is. As far as I can tell, nobody has ever even noticed this problem
    before, and we already have a trivial fix ("don't do it then") for the
    case Al actually did notice.

    The *only* case left as far as I can tell is the case where people do
    *not* copy the vdso, but simply generate (statically and/or
    dynamically with a JIT) the syscall instruction directly. And we
    cannot fix that, so stop even bothering to try. The absolute best we
    can do for that case is to just continue to do what we do now. WE
    SIMPLY HAVE NO CHOICE.

    I really don't see this as being worth this much discussion.

    Linus
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-08-23 02:25    [W:3.380 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site