lkml.org 
[lkml]   [2011]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [v3] firewire-sbp2: fix panic after rmmod with slow targets
On Aug 22 Chris Boot wrote:
> --- a/drivers/firewire/sbp2.c
> +++ b/drivers/firewire/sbp2.c
> @@ -1198,6 +1198,11 @@ static int sbp2_remove(struct device *dev)
> {
> struct fw_unit *unit = fw_unit(dev);
> struct sbp2_target *tgt = dev_get_drvdata(&unit->device);
> + struct sbp2_logical_unit *lu;
> +
> + list_for_each_entry(lu, &tgt->lu_list, link) {
> + cancel_delayed_work_sync(&lu->work);
> + }
>
> sbp2_target_put(tgt);
> return 0;

Thanks. I reproduced the bug, applied your patch, and confirmed that the
patch fixes the bug. Committed to linux1394-2.6.git but without the
curly braces.
--
Stefan Richter
-=====-==-== =--- =-===
http://arcgraph.de/sr/


\
 
 \ /
  Last update: 2011-08-23 01:25    [W:0.031 / U:1.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site