Messages in this thread | | | Date | Tue, 23 Aug 2011 01:21:35 +0200 | From | Stefan Richter <> | Subject | Re: [PATCH] [v3] firewire-sbp2: fix panic after rmmod with slow targets |
| |
On Aug 22 Chris Boot wrote: > --- a/drivers/firewire/sbp2.c > +++ b/drivers/firewire/sbp2.c > @@ -1198,6 +1198,11 @@ static int sbp2_remove(struct device *dev) > { > struct fw_unit *unit = fw_unit(dev); > struct sbp2_target *tgt = dev_get_drvdata(&unit->device); > + struct sbp2_logical_unit *lu; > + > + list_for_each_entry(lu, &tgt->lu_list, link) { > + cancel_delayed_work_sync(&lu->work); > + } > > sbp2_target_put(tgt); > return 0;
Thanks. I reproduced the bug, applied your patch, and confirmed that the patch fixes the bug. Committed to linux1394-2.6.git but without the curly braces. -- Stefan Richter -=====-==-== =--- =-=== http://arcgraph.de/sr/
| |