Messages in this thread | | | Subject | Re: [RFC][PATCH 2/6] x86, nmi: create new NMI handler routines | From | Peter Zijlstra <> | Date | Mon, 22 Aug 2011 16:13:49 +0200 |
| |
On Fri, 2011-08-19 at 16:37 -0400, Don Zickus wrote: > +int register_nmi_handler(unsigned int type, nmi_handler_t handler, > + unsigned long nmiflags, const char *devname) > +{ > + struct nmiaction *action; > + int retval; > + > + if (!handler) > + return -EINVAL; > + > + action = kzalloc(sizeof(struct nmiaction), GFP_KERNEL); > + if (!action) > + return -ENOMEM; > + > + action->handler = handler; > + action->flags = nmiflags; > + action->name = devname;
So you assume the string passed as devname remains stable..
> + > + retval = __setup_nmi(type, action); > + > + if (retval) > + kfree(action); > + > + return retval; > +} > +EXPORT_SYMBOL(register_nmi_handler);
Also, I'd use _GPL, the current register_die_notifier() is also. Preferably I'd not export NMI stuff at all.
| |