Messages in this thread | | | Date | Mon, 22 Aug 2011 08:55:28 -0500 | From | Timur Tabi <> | Subject | Re: [PATCH 1/2] sound/soc/fsl/p1022_ds.c: add missing of_node_put |
| |
Julia Lawall wrote: > From: Julia Lawall <julia@diku.dk> > > dma_channel_np has been accessed at this point, so decrease its reference > count before leaving the function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > identifier x; > expression E1!=0,E2,E3,E4; > statement S; > iterator I; > @@ > > ( > if (...) { ... when != of_node_put(x) > when != x = E3 > when != E3 = x > * return ...; > } > ... when != x = E2 > when != I(...,x,...) S > if (...) { ... when != x = E4 > of_node_put(x); ... return ...; } > ) > // </smpl> > > Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Timur Tabi <timur@freescale.com>
Thanks, Julia.
-- Timur Tabi Linux kernel developer at Freescale
| |