Messages in this thread | | | Subject | Re: [PATCH] x86: jump_label: arch_jump_label_text_poke_early: add missing __init | From | Steven Rostedt <> | Date | Fri, 19 Aug 2011 17:13:16 -0400 |
| |
On Fri, 2011-08-19 at 17:51 -0300, Kevin Winchester wrote: > On 19 August 2011 15:20, Steven Rostedt <rostedt@goodmis.org> wrote: > > On Tue, 2011-08-16 at 21:04 -0300, Kevin Winchester wrote: > >> arch_jump_label_text_poke_early calls text_poke_early, which is > >> an __init function. Thus arch_jump_label_text_poke_early should > >> be the same. > > > > but text_poke_early is not __init but instead __init_or_module. Your > > patch just caused this bug: > > > > Sorry about that. I have: > > # CONFIG_MODULES is not set > > which makes __init_or_module equivalent to __init for me. Thus the > patch was fine for my case, but I expect your modification is the > right thing to do overall.
Um yeah.
I guess you're another one just like Peter Zijlstra ...
"Modules? Modules? We don't need no stinking modules!"
-- Steve
| |