Messages in this thread Patch in this message | | | Subject | Re: [PATCH v5] usb: gadget: storage: make FSG_NUM_BUFFERS variable size | Date | Fri, 19 Aug 2011 19:34:43 +0200 | From | "Michal Nazarewicz" <> |
| |
On Fri, 19 Aug 2011 19:15:32 +0200, Per Forlin <per.forlin@linaro.org> wrote:
> 2011/8/19 Michal Nazarewicz <mina86@mina86.com>: >> On Fri, 19 Aug 2011 16:28:25 +0200, Per Forlin >> <per.forlin@stericsson.com> >> wrote: >>> >>> @@ -3605,6 +3608,9 @@ static int __init fsg_init(void) >>> int rc; >>> struct fsg_dev *fsg; >>> + if (!FSG_NUM_BUFFERS_IS_VALID(fsg_num_buffers)) >> >> Care to add pr_err() here? Or better yet, change >> fsg_num_buffers_is_valid() >> to a function, eg.: >> >> static inline int fsg_num_buffers_validate() >> { >> if (fsg_num_buffers && fsg_num_buffers <= 4) >> return 0; >> pr_err("fsg_num_buffers too high: %u\n", fsg_num_buffers); >> return -EINVAL; >> } >> > Look good. > This will permit only 1 buffer to be used. Is this intentionally? I'm > fine with it. > In Kconfig the range is 2 to 4. For debug purposes there may be a > point of permitting range 1 to 4.
Ah, sorry, no. I meant >= 2. Whether we want to allow a single buffer is another story (we might, why not?).
-- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michal "mina86" Nazarewicz (o o) ooo +-----<email/xmpp: mnazarewicz@google.com>-----ooO--(_)--Ooo--
| |