Messages in this thread | | | Date | Fri, 19 Aug 2011 16:58:15 +0200 | From | Oleg Nesterov <> | Subject | Re: + prctl-add-pr_setget_child_reaper-to-allow-simple-process-supervision .patch added to -mm tree |
| |
On 08/19, Kay Sievers wrote: > > On Fri, 2011-08-19 at 15:13 +0200, Oleg Nesterov wrote: > > On 08/19, Kay Sievers wrote: > > > But this has other (OK, minor) problems too, afaics. First of all, this > > ->has_child_subreaper = T is not right when the caller exits. We should > > not look for ->is_child_subreaper parent, our children should to find us. > > > > Right? > > The flags are still inherited. If the subreaper isn't there anymore, we > will look it up and not find it. I think that's ok for the very unusual > case that a service manager goes away and its children still run. We > will just fall back to the usual PID 1 logic.
Yes, yes, I didn't mean this is really buggy. Just a bit "strange". Anyway, this is fixed in v4 you sent.
> version 4:
Looks correct... But I don't trust myself. Especially after I missed the problem with klthreads ;)
I'll try to re-read this patch carefully tomorrow with a fresh head.
Oleg.
| |