Messages in this thread | | | Date | Thu, 18 Aug 2011 22:02:49 -0700 (PDT) | Subject | Re: [PATCH][Trivial] net/wan/hdlc_ppp: remove dead goto | From | David Miller <> |
| |
From: Jesper Juhl <jj@chaosbits.net> Date: Sat, 13 Aug 2011 01:39:43 +0200 (CEST)
> From: Jesper Juhl <jj@chaosbits.net> > > We'll either hit one of the case labels or the default in the switch > and in all cases do we then 'goto out', so having 'goto out' right > after the switch is pointless as we can never hit it - remove it. > > Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Probably a lot cleaner to use break statements in the switch() statement and keep this goto in place.
That's more straightforward control flow than what this thing is doing.
| |