lkml.org 
[lkml]   [2011]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] apm-emulation: use wait_event_freezable() instead of freezer_[do_not_]count()
Hi Tejun,

The patch looks fine even if I know nothing about this code.

But I have a bit off-topic question,

On 08/18, Tejun Heo wrote:
>
> vfork is moving away from freezer_[do_not_]count() one way or the
> other

Yes, I think we should do this in any case.

> Use wait_event_freezable() instead.
>
> The only annoyance is that wait_event_freezable() wakes up with
> -ERESTART if there are pending signals

IOW, we do not have wait_event_freezable_uninterruptible/etc.

Perhaps we can introduce TASK_FREEZABLE ? It should be used along
with TASK_UNINTERRUPTIBLE (like TASK_WAKEKILL). freeze_task() can
use TASK_INTERRUPTIBLE | FREEZABLE for wake_up.

vfork() can use FREEZABLE too (although this is not needed in the
long term, we should teach it to sleep in TASK_INTERRUPTIBLE).



But I feel you are going to reimplement freezer completely, in this
case please ignore.

Oleg.



\
 
 \ /
  Last update: 2011-08-18 19:41    [W:0.038 / U:0.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site