Messages in this thread | | | Subject | Re: [PATCH] powerpc/eeh: remove eeh_event_handler()->daemonize() | From | Benjamin Herrenschmidt <> | Date | Tue, 16 Aug 2011 14:17:15 -0500 |
| |
On Tue, 2011-08-16 at 21:08 +0200, Oleg Nesterov wrote: > daemonize() is only needed when a user-space task does kernel_thread(). > > eeh_event_handler() thread is created by the worker kthread, and thus > it doesn't need the soon-to-be-deprecated daemonize(). > > Note: looks like eeh_event_wq can be static and it can do all work > itself without kernel_thread(). > > Signed-off-by: Oleg Nesterov <oleg@redhat.com> > ---
Right, but don't bother cleaning that code too much tho :-) I'm quite close to reworking/refactoring most of it anyways.
Cheers, Ben.
> arch/powerpc/platforms/pseries/eeh_event.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- 3.1/arch/powerpc/platforms/pseries/eeh_event.c~3_daemonize_eeh 2011-04-06 21:33:42.000000000 +0200 > +++ 3.1/arch/powerpc/platforms/pseries/eeh_event.c 2011-08-16 21:03:56.000000000 +0200 > @@ -60,7 +60,7 @@ static int eeh_event_handler(void * dumm > struct eeh_event *event; > struct pci_dn *pdn; > > - daemonize ("eehd"); > + set_task_comm(current, "eehd"); > set_current_state(TASK_INTERRUPTIBLE); > > spin_lock_irqsave(&eeh_eventlist_lock, flags); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
| |