Messages in this thread | | | Date | Tue, 16 Aug 2011 19:25:36 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 26/41] sh: No need to reset handler if SA_ONESHOT |
| |
On 08/11, Matt Fleming wrote: > > get_signal_to_deliver() already resets the signal handler if > SA_ONESHOT is set in ka->sa.sa_flags, there's no need to do it again > in handle_signal(). Furthermore, because we were modifying > ka->sa.sa_handler without holding ->sighand->siglock there's the > potential we can race with another thread if it modifies the signal > handlers.
Again ;) the patch is fine, the changelog is not right.
Oleg.
| |