Messages in this thread | | | Date | Mon, 15 Aug 2011 15:46:07 +1000 | From | Stephen Rothwell <> | Subject | Re: [PATCH] mmc: sdhci-esdhc-imx: add missing inclusion of linux/module.h |
| |
Hi,
On Mon, 15 Aug 2011 13:35:58 +0800 Shawn Guo <shawn.guo@linaro.org> wrote: > > On 15 August 2011 11:54, Chris Ball <cjb@laptop.org> wrote: > > > > On Sun, Aug 14 2011, Shawn Guo wrote: > >> There are following warning and error when compiling the driver. > >> The patch adds the missing inclusion of linux/module.h to fix them. > >> > >> drivers/mmc/host/sdhci-esdhc-imx.c:87:1: warning: data definition has > >> no type or storage class > > > > Pushed to mmc-next for 3.1. I don't see these on my imx build with > > CONFIG_MMC_SDHCI_ESDHC_IMX=m, so it'd be useful to see your .config > > so that I'm able to reproduce in future. > > > I guess it's not about .config but sources. I spot this on > linux-next-20110812. Are you trying the same tree? I will test > v3.1-rc2 tag when I can actually fetch it. (Linus released it, but it > has not been available with 'git fetch' yet.)
It could well be an interaction with the module.h split up, in which case it will only appear in linux-next. That said, I don;t get that error in my manual builds, so the config (or at least ARCH) could be useful.
-- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [unhandled content-type:application/pgp-signature] | |