Messages in this thread | | | Date | Sun, 14 Aug 2011 18:15:32 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 1/2] add SA_CLDREBOOT flag |
| |
On 08/11, Daniel Lezcano wrote: > > Add the SA_CLDREBOOT flag to enable the CLD_REBOOT on SIGCHLD > when a process of a child pid namespace calls the reboot syscall.
I doubt this is really useful in general. SIGCHLD doesn't queue, if the parent of init already has the pending SIGCHLD it won't see CLD_REBOOTED anyway. Anyway, you do not need a special helper to fill siginfo.
And personally I strongly dislike SA_CLDREBOOT. For what? Imho, this is unnecessary complication. If we want SIGCHLD-on-reboot, just send it unconditionally.
Oleg.
| |