lkml.org 
[lkml]   [2011]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] blktrace: add FLUSH/FUA support
On 2011-08-10 15:53, Jeff Moyer wrote:
> Namhyung Kim <namhyung@gmail.com> writes:
>
>> Add FLUSH/FUA support to blktrace. As FLUSH precedes WRITE and/or
>> FUA follows WRITE, use the same 'F' flag for both cases and
>> distinguish them by their (relative) position. The end results
>> look like (other flags might be shown also):
>>
>> - WRITE: W
>> - WRITE_FLUSH: FW
>> - WRITE_FUA: WF
>> - WRITE_FLUSH_FUA: FWF
>
> I was hoping we'd go with Jens' suggestion of relacing W with F for flush,
> and have FUA appear after that. However, I can live with this, so if
> others like it, it's fine by me.

The single 'F' would have been cleaner, but at least this is consistent.
Applied, thanks.

--
Jens Axboe



\
 
 \ /
  Last update: 2011-08-11 10:39    [W:0.027 / U:0.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site