Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH v6 2/2] Output stall data in debugfs | From | Peter Zijlstra <> | Date | Thu, 11 Aug 2011 21:57:28 +0200 |
| |
On Thu, 2011-08-11 at 12:51 -0700, Alex Neronskiy wrote: > I didn't want to hold on to a lock while the lines were iterated over, > and instead just dump it in one go. I guess it's not a big deal to do > that, though. Nonetheless, is one page not enough?
The "[<%pK>] %pS\n" that's 6bytes + 8bytes + ~64bytes making 78 bytes at worst (assuming we have a symbol length max of 64 that is), that yields 4096/78 = 52, so yeah, just about enough since your trace depth is limited at 50. But its close enough to make me feel uncomfortable.
| ![\](/images/icornerr.gif) |