Messages in this thread | | | Date | Thu, 11 Aug 2011 09:51:34 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH RESEND] Input: tegra-kbc - correct call to input_free_device |
| |
On Thu, Aug 11, 2011 at 09:42:54AM -0700, Stephen Warren wrote: > Axel Lin wrote at Thursday, August 11, 2011 2:49 AM: > > If kzalloc for kbc fails, then we have NULL pointer dereference while > > calling input_free_device(kbc->idev) in the error handling. > > So it is safer to always use the original name, input_dev. > > > > Signed-off-by: Axel Lin <axel.lin@gmail.com> > > Reviewed-by: Stephen Warren <swarren@nvidia.com>
Gah, sorry, already pushed into my public branch so won't be able so add your reviewed-by...
-- Dmitry
| |