lkml.org 
[lkml]   [2011]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] Enable 'make CONFIG_FOO=y oldconfig'
From
Date
On Thu, 2011-08-11 at 13:15 +0200, Andreas Schwab wrote:
> > That would be cute, but I'm not sure how to undefine something set on
> > the command line:
> >
> > $ cat > Makefile <<EOF
> > undefine BAR
>
> override undefine BAR

Thanks. So we don't really need to change the auto.conf syntax; we could
just do:

$(foreach var, $(filter CONFIG_%,$(.VARIABLES)), $(eval override undefine $(var)))

But still I suspect we might *not* want that for options set on the
command line. We *don't* want 'make CONFIG_FOO=y oldconfig bzImage' to
say 'you can't enable CONFIG_FOO' and then build the bzImage anyway.

I'll look at making it work only if what's on the command line matches
the output of kconfig, but I'm also relatively content with saying "no
config overrides on the command line for build targets"

--
dwmw2



\
 
 \ /
  Last update: 2011-08-11 13:43    [W:0.149 / U:1.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site