Messages in this thread | | | Date | Tue, 26 Jul 2011 16:17:37 -0700 | From | Chase Douglas <> | Subject | Re: [PATCH 9/9 v2] Input: synaptics - process finger (<=5) transitions |
| |
On 07/22/2011 09:11 PM, Daniel Kurtz wrote: > On Sat, Jul 23, 2011 at 9:02 AM, Chase Douglas > <chase.douglas@canonical.com> wrote: >> >> On 07/20/2011 06:39 AM, djkurtz@chromium.org wrote: >>> From: Daniel Kurtz <djkurtz@chromium.org> >>> >>> Synaptics image sensor touchpads track up to 5 fingers, but only report 2. >>> They use a special "TYPE=2" (AGM-CONTACT) packet type that reports >>> the number of tracked fingers and which finger is reported in the SGM >>> and AGM packets. >>> >>> With this new packet type, it is possible to tell userspace when 4 or 5 >>> fingers are touching. >> >> Maybe I'm blind, but I don't see where the QUADTAP and QUINTAP values >> are set in the events. I see where the bits are set during >> initialization, but not during use. > > It's subtle. > The firmware actually report 4/5 in the AGM-CONTACT packet, which the > agm packet parser sets directly in mt_state->count. > This is then reported to userspace when synaptics_report_mt() calls > input_mt_report_finger_count(dev, mt_state->count), which now supports > QUINTTAP (see patch #8).
Ahh, thanks! Conditional upon getting the previous patches merged in some fashion:
Acked-by: Chase Douglas <chase.douglas@canonical.com>
| |