Messages in this thread | | | From | Paul Menage <> | Date | Tue, 26 Jul 2011 11:40:26 -0700 | Subject | Re: [PATCH v3] blk-cgroup:be able to remove the record of unplugged device |
| |
On Tue, Jul 26, 2011 at 10:41 AM, Vivek Goyal <vgoyal@redhat.com> wrote: > They have but the context where temp is being used to figure out if it > is a deletion rule is generic. So if a rule is being deleted (be it > weight, bps or iops), we are going to parse it early in the function. > So in that context not calling it "weight" makes sense to me. > > We use bps, iops names only after knowing the value type.
Fair enough - but in that case, wouldn't it make sense to make "temp" a u64 and just parse it once, rather than reparsing the iops/bps later in their switch cases?
Paul
| |