Messages in this thread | | | From | Jim Cromie <> | Date | Tue, 26 Jul 2011 10:21:15 -0600 | Subject | Re: [PATCH 11/25] dynamic_debug: factor show_ddebug_query out of ddebug_parse_query |
| |
On Tue, Jul 26, 2011 at 1:15 AM, Bart Van Assche <bvanassche@acm.org> wrote: > On Mon, Jul 25, 2011 at 11:42 PM, Jim Cromie <jim.cromie@gmail.com> wrote: >> @@ -435,6 +448,10 @@ static int ddebug_exec_queries(char *query) >> char *split; >> int i, errs = 0, exitcode = 0, rc; >> >> + prbuf_query = kmalloc(1024, GFP_KERNEL); >> + if (prbuf_query == NULL) >> + return -ENOMEM; >> + >> for (i = 0; query; query = split) { >> split = strpbrk(query, ";\n"); >> if (split) >> @@ -452,6 +469,7 @@ static int ddebug_exec_queries(char *query) >> } >> i++; >> } >> + kfree(prbuf_query); > > The above changes invoke memory allocation and deallocation. But the > allocated buffer isn't used anywhere - neither in this patch nor in > any later patch ??? > > Bart. >
nope, that was a vestige of code before rework to use kasprintf. now excised.
thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |