Messages in this thread | | | Date | Tue, 26 Jul 2011 14:51:51 +0100 | From | Mel Gorman <> | Subject | Re: [patch 1/5] mm: page_alloc: increase __GFP_BITS_SHIFT to include __GFP_OTHER_NODE |
| |
On Mon, Jul 25, 2011 at 10:19:15PM +0200, Johannes Weiner wrote: > From: Johannes Weiner <hannes@cmpxchg.org> > > __GFP_OTHER_NODE is used for NUMA allocations on behalf of other > nodes. It's supposed to be passed through from the page allocator to > zone_statistics(), but it never gets there as gfp_allowed_mask is not > wide enough and masks out the flag early in the allocation path. > > The result is an accounting glitch where successful NUMA allocations > by-agent are not properly attributed as local. > > Increase __GFP_BITS_SHIFT so that it includes __GFP_OTHER_NODE. > > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
You're right, this should be merged separately.
Acked-by: Mel Gorman <mgorman@suse.de>
-- Mel Gorman SUSE Labs
| |