Messages in this thread | | | Subject | Re: [PATCH] vfs: dont chain pipe/anon/socket on superblock s_inodes list | From | Eric Dumazet <> | Date | Tue, 26 Jul 2011 12:43:33 +0200 |
| |
Le mardi 26 juillet 2011 à 05:42 -0400, Christoph Hellwig a écrit : > On Tue, Jul 26, 2011 at 11:36:34AM +0200, Eric Dumazet wrote: > > [PATCH v2] vfs: dont chain pipe/anon/socket on superblock s_inodes list > > > > Workloads using pipes and sockets hit inode_sb_list_lock contention. > > > > superblock s_inodes list is needed for quota, dirty, pagecache and > > fsnotify management. pipe/anon/socket fs are clearly not candidates for > > these. > > > > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> > > Looks good to me, > > Reviewed-by: Christoph Hellwig <hch@lst.de> >
Thanks !
BTW, we have one atomic op that could be avoided in new_inode()
spin_lock(&inode->i_lock); inode->i_state = 0; spin_unlock(&inode->i_lock);
can probably be changed to something less expensive...
inode->i_state = 0; smp_wmb();
Not clear if we really need a memory barrier either....
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |