lkml.org 
[lkml]   [2011]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: About bittiming calculation result
    Date
    On Monday, February 07, 2011 9:01 PM, Wolfgang Grandegger wrote
    >
    > Well, only prop_seg+phase_seg=tseg1 is relevant and the
    > pch_can driver sets the allowed minimum "tseg1_min1" currently to 1:
    >
    > static struct can_bittiming_const pch_can_bittiming_const = {
    > .name = KBUILD_MODNAME,
    > .tseg1_min = 1,
    > .tseg1_max = 16,
    > .tseg2_min = 1,
    > .tseg2_max = 8,
    > .sjw_max = 4,
    > .brp_min = 1,
    > .brp_max = 1024, /* 6bit + extended 4bit */
    > .brp_inc = 1,
    > };
    >
    > > seg1/seg2/sjw/prop_seg must be more than 1 ?
    >
    > Then "tseg1_min" should be set to *2*.

    Though some drivers accepted by upstream have parameter "tseg1_min" as 1,
    Sould we release the patch like below ?
    - .tseg1_min = 1,
    + .tseg1_min = 2,

    Thanks,
    -----------------------------------------
    Tomoya MORINAGA
    OKI SEMICONDUCTOR CO., LTD.



    \
     
     \ /
      Last update: 2011-02-08 02:13    [W:4.824 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site