lkml.org 
[lkml]   [2011]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] CRED: Fix BUG() upon security_cred_alloc_blank() failure
On Mon, 07 Feb 2011 13:36:10 +0000
David Howells <dhowells@redhat.com> wrote:

> In cred_alloc_blank() since 2.6.32, abort_creds(new) is called with
> new->security == NULL and new->magic == 0 when security_cred_alloc_blank()
> returns an error. As a result, BUG() will be triggered if SELinux is enabled
> or CONFIG_DEBUG_CREDENTIALS=y.
>
> If CONFIG_DEBUG_CREDENTIALS=y, BUG() is called from __invalid_creds() because
> cred->magic == 0. Failing that, BUG() is called from selinux_cred_free()
> because selinux_cred_free() is not expecting cred->security == NULL. This does
> not affect smack_cred_free(), tomoyo_cred_free() or apparmor_cred_free().
>
> Fix these bugs by
>
> (1) Set new->magic before calling security_cred_alloc_blank().
>
> (2) Handle null cred->security in creds_are_invalid() and selinux_cred_free().

You don't feel that these two patches should be backported into -stable?


\
 
 \ /
  Last update: 2011-02-08 00:27    [W:0.557 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site