Messages in this thread | | | Date | Fri, 04 Feb 2011 20:32:17 +0300 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH] perf, x86: P4 PMU -- Fix unflagged overflows test |
| |
On 02/04/2011 07:59 PM, Don Zickus wrote: > On Fri, Feb 04, 2011 at 03:17:28PM +0300, Cyrill Gorcunov wrote: >> Please apply it, sorry for non-inlined patch (have a web access only at moment). >> >> Note that I've tested the patch on non-HT machine so if someone have HT'ed one >> -- it would be great to test the patch there. > > Hmm. For some reason, when I enable the kgdb testsuite, the box fails to > boot with hardlockup issues. It seems like the code is swallowing the > NMIs? I basically applied this patch on top of 2.6.38-rc3 and ran it on my > Xeon box (p4 w/HT). > > Cheers, > Don
Interesting, seems old kgdb issue got back. The former unknown nmi problem is due to commit 047a3772feaae8e43d81d790f3d3f80dae8ae676 which assumed that counter stays zero when unflagged overflow happened, but it seems this is not what happens on hw level. I noted that at moment of nmi the counter reached some positive value so the new patch simply checks for negative bit being set.
I must admit I forgot to test with kgdb testsuite at bootup time and I'll be able to test this at monday in best case. I'll try to figure out what might happen by code reading for a while (the only idea comes is that nmi from kgdb get slipped with one issued by a perf).
-- Cyrill
| |