Messages in this thread | | | Date | Thu, 3 Feb 2011 12:04:03 +0200 | From | Gleb Natapov <> | Subject | Re: [PATCH] Fix EDD3.0 data verification. |
| |
On Wed, Feb 02, 2011 at 11:56:55AM -0800, H. Peter Anvin wrote: > On 02/02/2011 09:59 AM, Gleb Natapov wrote: > > > > Ah I see what length you were referring to params->device_path_info_length. > > If we will use that then we will get correct checksum for BIOSes that work > > according to phoenix spec too, but edd_show_interface() and edd_show_host_bus() > > handle only T13 spec so the information they show can be incorrect. I can > > change code to check that params->device_path_info_length == 44 in addition > > to checking csum. What do you think? > > > > Yes, you need to check both. OK.
> > This is really a union of two similar-but-not-identical structures > distinguished by the length field. > Yes, unfortunately phoenix spec lacks some vital information that is needed to find the device edd entry corresponds too. SCSI target or IDE channel for instance.
-- Gleb.
| |