Messages in this thread Patch in this message | | | From | Ian Kent <> | Subject | [PATCH 3/4] autofs4 - fix dentry leak in autofs4_expire_direct() | Date | Tue, 01 Mar 2011 12:57:13 +0800 |
| |
There is a missing dput() when returning from autofs4_expire_direct() when we see that the dentry is already a pending mount.
Signed-off-by: Ian Kent <raven@themaw.net> ---
fs/autofs4/expire.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/autofs4/expire.c b/fs/autofs4/expire.c index c896dd6..c403abc 100644 --- a/fs/autofs4/expire.c +++ b/fs/autofs4/expire.c @@ -290,10 +290,8 @@ struct dentry *autofs4_expire_direct(struct super_block *sb, spin_lock(&sbi->fs_lock); ino = autofs4_dentry_ino(root); /* No point expiring a pending mount */ - if (ino->flags & AUTOFS_INF_PENDING) { - spin_unlock(&sbi->fs_lock); - return NULL; - } + if (ino->flags & AUTOFS_INF_PENDING) + goto out; if (!autofs4_direct_busy(mnt, root, timeout, do_now)) { struct autofs_info *ino = autofs4_dentry_ino(root); ino->flags |= AUTOFS_INF_EXPIRING; @@ -301,6 +299,7 @@ struct dentry *autofs4_expire_direct(struct super_block *sb, spin_unlock(&sbi->fs_lock); return root; } +out: spin_unlock(&sbi->fs_lock); dput(root);
| |