Messages in this thread | | | Date | Mon, 28 Feb 2011 09:06:42 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 1/4] printk: Allocate kernel log buffer earlier |
| |
* Yinghai Lu <yinghai@kernel.org> wrote:
> + new_addr = memblock_alloc(new_log_buf_len, PAGE_SIZE); > + if (new_addr != MEMBLOCK_ERROR) > + new_log_buf = __va(new_addr); > + else > + new_log_buf = alloc_bootmem(new_log_buf_len);
alloc_bootmem() can fail, especially if someone uses a too large boot parameter value - and your code does not check for failure.
Thanks,
Ingo
| |