Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 28 Feb 2011 01:04:14 -0700 | From | Grant Likely <> | Subject | Re: [RFC PATCH] ipmi: convert OF driver to platform driver |
| |
On Thu, Feb 24, 2011 at 03:34:50PM +0100, Arnd Bergmann wrote: > On Thursday 24 February 2011, Grant Likely wrote: > > On Wed, Feb 23, 2011 at 03:37:59PM -0600, Rob Herring wrote: > > > From: Rob Herring <rob.herring@calxeda.com> > > > > > > of_bus is deprecated in favor of the plain platform bus. This patch > > > merges the ipmi OF driver with the existing platform driver. > > > > > > CONFIG_PPC_OF occurrances are removed or replaced with CONFIG_OF. > > > > > > Compile tested with and without CONFIG_OF. Tested OF probe and > > > default probe cases. > > > > > > Signed-off-by: Rob Herring <rob.herring@calxeda.com> > > > > Wow. That driver does some weird things with the driver model that > > really should be cleaned up. That said, this change looks correct. > > I'll add it to my tree and see how it goes. > > Please keep me in the look when you want to do further into cleaning > this up. The OF code was initially done for the QS21 running SLOF, and > predates the flattened device tree specs.
Will do. I've got no plans to fiddle with this code beyond getting rid of the of_platform_driver abstractions, but I'll keep my eye out for changes that you should be cc'd on.
g.
| ![\](/images/icornerr.gif) |