Messages in this thread | | | Date | Mon, 28 Feb 2011 16:47:58 +0100 | From | Jiri Slaby <> | Subject | Re: [PATCH v2 -resend#1 1/1] V4L: videobuf, don't use dma addr as physical |
| |
On 02/28/2011 03:53 PM, Konrad Rzeszutek Wilk wrote: > On Mon, Feb 28, 2011 at 10:37:02AM +0100, Jiri Slaby wrote: >> mem->dma_handle is a dma address obtained by dma_alloc_coherent which >> needn't be a physical address in presence of IOMMU. So ensure we are > > Can you add a comment why you are fixing it? Is there a bug report for this? > Under what conditions did you expose this fault?
No, by a just peer review when I was looking for something completely different.
> You also might want to mention that "needn't be a physical address as > a hardware IOMMU can (and most likely) will return a bus address where > physical != bus address."
Mauro, do you want me to resend this with such an udpate in the changelog?
> Otherwise you can stick 'Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>' > on it.
thanks, -- js suse labs
| |