lkml.org 
[lkml]   [2011]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 -tip] perf: x86, add SandyBridge support
From
Date
On Mon, 2011-02-28 at 22:24 +0800, Peter Zijlstra wrote:
> On Mon, 2011-02-28 at 22:21 +0800, Lin Ming wrote:
> > > > #define INTEL_EVENT_CONSTRAINT(c, n) \
> > > > EVENT_CONSTRAINT(c, n, ARCH_PERFMON_EVENTSEL_EVENT)
> > > > +#define INTEL_EVENT_CONSTRAINT2(c, n) \
> > > > + EVENT_CONSTRAINT(c, n, INTEL_ARCH_EVENT_MASK)
> > >
> > > That's a particularly bad name, how about something like
> > >
> > > INTEL_UEVENT_CONSTRAINT or somesuch.
> >
> > OK.
> >
> > But any case it's duplicated with PEBS_EVENT_CONSTRAINT.
> >
> > #define PEBS_EVENT_CONSTRAINT(c, n) \
> > EVENT_CONSTRAINT(c, n, INTEL_ARCH_EVENT_MASK)
>
> Ah, indeed, so maybe we can remove PEBS_EVENT_CONSTRAINT and use regular
> INTEL_*_CONSTRAINTS there, that could also help for PEBS events where
> all umasks are allowed (not sure there are any such things but the SNB
> PEBS list was quite large).

Yes, there are, for example, BR_INST_RETIRED.*



\
 
 \ /
  Last update: 2011-02-28 15:47    [W:0.047 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site