lkml.org 
[lkml]   [2011]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RESEND v2] i2c-eg20t: support new device OKI SEMICONDUCTOR ML7213 IOH
On Mon, Feb 28, 2011 at 03:54:32PM +0900, Tomoya MORINAGA wrote:
> - ret = i2c_add_adapter(&(adap_info->pch_data.pch_adapter));
> + pch_adap->dev.parent = &pdev->dev;
>
> - if (ret) {
> - pch_pci_err(pdev, "i2c_add_adapter FAILED\n");
> - goto err_i2c_add_adapter;
> - }
> + ret = i2c_add_adapter(pch_adap);
> + if (ret) {
> + pch_pci_err(pdev, "i2c_add_adapter[ch:%d] FAILED\n", i);
> + goto err_i2c_add_adapter;

I think goto err_request_irq was intended here. On a side note, it's
always better to name goto destinations after the destination instead
of the starting point. In this case, we have two gotos to one
destination and the label err_request_irq makes no sense.

regards,
dan carpenter



\
 
 \ /
  Last update: 2011-02-28 12:55    [W:0.137 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site