Messages in this thread | | | Subject | Re: [cpuops cmpxchg double V3 3/5] Generic support for this_cpu_cmpxchg_double | From | Steven Rostedt <> | Date | Fri, 25 Feb 2011 15:53:42 -0500 |
| |
On Fri, 2011-02-25 at 14:44 -0600, Christoph Lameter wrote: > On Fri, 25 Feb 2011, Steven Rostedt wrote: > > > > + VM_BUG_ON((unsigned long)(&pcp1) % (2 * sizeof(pcp1))); \ > > > + VM_BUG_ON((unsigned long)(&pcp2) != (unsigned long)(&pcp1) + sizeof(pcp1));\ > > > + VM_BUG_ON(sizeof(pcp1) != sizeof(pcp2)); \ > > > > Since this is a macro, and it looks like all these are constants (sizeof > > and addresses), couldn't you just do a BUILD_BUG_ON() instead? > > The addresses are not constant.
I was thinking that if these are per_cpu then they would be global and thus constant. But those are done at link time, which is too late.
OK, nevermind ;)
-- Steve
| |