lkml.org 
[lkml]   [2011]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Network driver for PMC-Sierra MSP71xx TSMAC.
On Thu, 24 Feb 2011 17:27:40 +0530
"Anoop P.A" <anoop.pa@gmail.com> wrote:

> +#if PMC_MSP_TSMAC
> +
> +config DESC_ALL_DSPRAM
> + bool "TX/RX Descriptors in DSPRAM"
> + depends on DMA_TO_SPRAM
> + default n
> + help
> + Turning this on puts TX/RX descriptors in DSPRAM. Otherwise they are in
> + DRAM.
> +
> +config TSMAC_LINELOOPBACK_FEATURE
> + bool "lineLoopBack command"
> + default n
> + help
> + Turning this on includes the lineLoopBack command in the driver's proc
> + interface. Echoing 1 into the lineLoopBack results in all rx packets
> + being transmitted out the same port.
> +
> +config TSMAC_TEST_CMDS
> + bool "test commands"
> + default n
> + help
> + Turning this on includes the testing commands in the driver's proc
> + interface. These are used internally by PMC.
> +

Too many config options. Usually no config options is best, or at
most one debug option.

The proc interface for testing should be replaced with debugfs


\
 
 \ /
  Last update: 2011-02-24 18:49    [W:0.032 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site