lkml.org 
[lkml]   [2011]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] staging: remove null checks before kfree
On Thu, Feb 24, 2011 at 11:08:29AM -0500, Steven Rostedt wrote:
> On Tue, Feb 22, 2011 at 03:53:40AM -0500, Ilia Mirkin wrote:
> > This patch was created with the following semantic patch:
> >
> > // <smpl>
> > @@
> > expression E;
> > @@
> >
> > - if (E != NULL) kfree(E);
> > + kfree(E);
> > // </smpl>
>
> OK, so when will we be removing the unlikely() from the implementations
> of kfree()?
>
> if (unlikely(ZERO_OR_NULL_PTR(block)))
> return;

Have you run the tool that checks for unlikely being true here? Odds
are, even with all of these changes, the large majority of the time
kfree is called, it has a valid pointer.

thanks,

greg k-h


\
 
 \ /
  Last update: 2011-02-24 18:15    [W:0.098 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site